Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: make sure to signal tiproxy to stop #2318

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 14, 2023

What problem does this PR solve?

Closes #2317

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

TiUP Playground was updated to signal TiProxy to stop gracefully when stopping the playground.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bff409d) 55.52% compared to head (e638865) 55.51%.

❗ Current head e638865 differs from pull request most recent head 76d8e8f. Consider uploading reports for the commit 76d8e8f to get more accurate results

Files Patch % Lines
components/playground/playground.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2318      +/-   ##
==========================================
- Coverage   55.52%   55.51%   -0.01%     
==========================================
  Files         325      325              
  Lines       34725    34729       +4     
==========================================
- Hits        19280    19278       -2     
- Misses      13143    13147       +4     
- Partials     2302     2304       +2     
Flag Coverage Δ
playground 15.25% <0.00%> (-<0.01%) ⬇️
tiup 33.48% <ø> (ø)
unittest 22.38% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 15, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 15, 2023
@ti-chi-bot ti-chi-bot bot added the approved label Nov 15, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Nov 15, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

@dveeden: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 15, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-15 05:45:08.721072042 +0000 UTC m=+4227906.308182188: ☑️ agreed by kaaaaaaang.
  • 2023-11-15 05:45:29.060759743 +0000 UTC m=+4227926.647869884: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-11-15 07:26:17.995436736 +0000 UTC m=+4233975.582546882: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 520c05a into pingcap:master Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiUP Playground fails to stop with TiProxy
3 participants