Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global component_sources #2320

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from srstack November 15, 2023 07:09
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (520c05a) 55.52% compared to head (5d643a7) 50.69%.

❗ Current head 5d643a7 differs from pull request most recent head 4ba7377. Consider uploading reports for the commit 4ba7377 to get more accurate results

Files Patch % Lines
pkg/cluster/spec/tikv_cdc.go 0.00% 7 Missing ⚠️
components/dm/spec/logic.go 57.14% 4 Missing and 2 partials ⚠️
pkg/cluster/spec/dashboard.go 0.00% 6 Missing ⚠️
pkg/cluster/spec/instance.go 20.00% 2 Missing and 2 partials ⚠️
pkg/cluster/spec/cdc.go 57.14% 2 Missing and 1 partial ⚠️
pkg/cluster/spec/drainer.go 57.14% 2 Missing and 1 partial ⚠️
pkg/cluster/spec/pd.go 57.14% 2 Missing and 1 partial ⚠️
pkg/cluster/spec/pump.go 57.14% 2 Missing and 1 partial ⚠️
pkg/cluster/spec/tidb.go 50.00% 2 Missing and 1 partial ⚠️
pkg/cluster/spec/tiflash.go 57.14% 2 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
- Coverage   55.52%   50.69%   -4.83%     
==========================================
  Files         325      325              
  Lines       34729    34753      +24     
==========================================
- Hits        19280    17615    -1665     
- Misses      13147    14997    +1850     
+ Partials     2302     2141     -161     
Flag Coverage Δ
cluster 37.65% <48.72%> (-7.23%) ⬇️
dm 25.45% <18.28%> (-0.02%) ⬇️
playground 15.22% <0.00%> (-0.03%) ⬇️
tiup 33.48% <ø> (ø)
unittest 22.29% <6.45%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nexustar nexustar force-pushed the add_component_source branch 2 times, most recently from 81ae3d9 to a5ecd4b Compare November 15, 2023 07:45
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 15, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-15 10:55:27.078226329 +0000 UTC m=+4246524.665336473: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/merge

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit c0abd84 into pingcap:master Nov 15, 2023
18 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.14.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants