Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix metric targets will be overrided #2324

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Nov 30, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from srstack November 30, 2023 03:43
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3e9fc5) 55.52% compared to head (ca73d23) 55.52%.

❗ Current head ca73d23 differs from pull request most recent head 06ce900. Consider uploading reports for the commit 06ce900 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2324      +/-   ##
==========================================
- Coverage   55.52%   55.52%   -0.00%     
==========================================
  Files         325      325              
  Lines       34753    34757       +4     
==========================================
+ Hits        19295    19296       +1     
- Misses      13145    13147       +2     
- Partials     2313     2314       +1     
Flag Coverage Δ
playground 15.24% <100.00%> (+<0.01%) ⬆️
tiup 33.48% <ø> (ø)
unittest 22.30% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 30, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 03:48:06.18855599 +0000 UTC m=+1067314.853782184: ☑️ agreed by kaaaaaaang.

@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Nov 30, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

1 similar comment
@rleungx
Copy link
Member

rleungx commented Nov 30, 2023

/lgtm

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit c53895c into pingcap:master Nov 30, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants