Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typo 'waitting' to 'waiting' in output messages within pdapi.go. #2330

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

guangleibao
Copy link
Contributor

What problem does this PR solve?

Correct typo in pdapi messages.

What is changed and how it works?

Change the string from 'waitting' to 'waiting'. There are 6 'waiiting' typos in pdapi.go:

pkg/cluster/api/pdapi.go:288:           pc.l().Debugf("Still waitting for the PD leader to be elected")
pkg/cluster/api/pdapi.go:289:           return perrs.New("still waitting for the PD leader to be elected")
pkg/cluster/api/pdapi.go:447:           pc.l().Debugf("Still waitting for the PD leader to transfer")
pkg/cluster/api/pdapi.go:448:           return perrs.New("still waitting for the PD leader to transfer")
pkg/cluster/api/pdapi.go:527:                   "\t  Still waitting for %d store leaders to transfer...",
pkg/cluster/api/pdapi.go:735:                           return perrs.New("still waitting for the PD node to be deleted")

@ti-chi-bot ti-chi-bot bot requested a review from srstack December 14, 2023 10:40
@CLAassistant
Copy link

CLAassistant commented Dec 14, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ced2d6d) 47.65% compared to head (1eefbee) 52.47%.

❗ Current head 1eefbee differs from pull request most recent head fb1af3a. Consider uploading reports for the commit fb1af3a to get more accurate results

Files Patch % Lines
pkg/cluster/api/pdapi.go 16.67% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2330      +/-   ##
==========================================
+ Coverage   47.65%   52.47%   +4.81%     
==========================================
  Files         307      325      +18     
  Lines       33819    34764     +945     
==========================================
+ Hits        16116    18240    +2124     
+ Misses      15715    14319    -1396     
- Partials     1988     2205     +217     
Flag Coverage Δ
cluster 39.19% <16.67%> (-2.76%) ⬇️
dm 25.55% <0.00%> (?)
playground 15.25% <0.00%> (?)
tiup 33.48% <ø> (ø)
unittest 22.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 14, 2023
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 14, 2023
@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Dec 14, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 18, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 19, 2023
@breezewish
Copy link
Member

@guangleibao Please sign the CLA agreement to get PR merged. Thanks a lot!

@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 19, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-14 10:44:11.117280446 +0000 UTC m=+525742.154507370: ☑️ agreed by kaaaaaaang.
  • 2023-12-18 08:56:02.042308669 +0000 UTC m=+864853.079535596: ✖️🔁 reset by ti-chi-bot[bot].
  • 2023-12-19 06:10:55.182456332 +0000 UTC m=+941346.219683258: ☑️ agreed by breezewish.
  • 2023-12-19 09:44:06.277219853 +0000 UTC m=+954137.314446782: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2023

New changes are detected. LGTM label has been removed.

@guangleibao
Copy link
Contributor Author

TiUP CLA agreement signed.

@breezewish breezewish merged commit 0a96dad into pingcap:master Dec 20, 2023
10 of 19 checks passed
@breezewish
Copy link
Member

Thanks for your contribution!

kaaaaaaang pushed a commit that referenced this pull request Jan 12, 2024
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants