Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: fix cannot clone without global version #2359

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from srstack January 10, 2024 14:51
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2024
@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Jan 10, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 10, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-10 17:26:36.730336162 +0000 UTC m=+464186.314589856: ☑️ agreed by kaaaaaaang.

Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b246a3) 55.43% compared to head (24e3190) 35.75%.

❗ Current head 24e3190 differs from pull request most recent head c4c6113. Consider uploading reports for the commit c4c6113 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2359       +/-   ##
===========================================
- Coverage   55.43%   35.75%   -19.68%     
===========================================
  Files         329      251       -78     
  Lines       34841    27429     -7412     
===========================================
- Hits        19314     9807     -9507     
- Misses      13216    16342     +3126     
+ Partials     2311     1280     -1031     
Flag Coverage Δ
cluster 35.75% <ø> (-9.00%) ⬇️
dm ?
playground ?
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot merged commit 30d4413 into pingcap:master Jan 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“no version specified“ when clone without global version
3 participants