Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix tiproxy scale #2365

Merged
merged 8 commits into from
Feb 29, 2024
Merged

playground: fix tiproxy scale #2365

merged 8 commits into from
Feb 29, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 18, 2024

What problem does this PR solve?

missing sanitizeComponentConfig.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Fix tiproxy playground scale out

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from srstack January 18, 2024 02:34
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.91%. Comparing base (38b6c96) to head (5913469).

❗ Current head 5913469 differs from pull request most recent head d7a4bce. Consider uploading reports for the commit d7a4bce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
+ Coverage   55.77%   55.91%   +0.14%     
==========================================
  Files         329      329              
  Lines       35025    35032       +7     
==========================================
+ Hits        19534    19586      +52     
+ Misses      13154    13110      -44     
+ Partials     2337     2336       -1     
Flag Coverage Δ
cluster 45.13% <ø> (-0.18%) ⬇️
dm 25.51% <ø> (-0.05%) ⬇️
playground 15.79% <100.00%> (+0.62%) ⬆️
tiup 33.60% <ø> (-0.05%) ⬇️
unittest 22.24% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox changed the title playground: fix tiproxy scale out playground: fix tiproxy scale Jan 18, 2024
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2024
Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 29, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 29, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 29, 2024
@xhebox
Copy link
Collaborator Author

xhebox commented Feb 2, 2024

/retest

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 29, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-29 05:56:06.194282659 +0000 UTC m=+1372207.758580688: ☑️ agreed by kaaaaaaang.
  • 2024-01-29 07:03:52.465732209 +0000 UTC m=+1376274.030029909: ✖️🔁 reset by ti-chi-bot[bot].
  • 2024-02-29 09:45:23.840984442 +0000 UTC m=+1128012.588607554: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot merged commit 8164c78 into pingcap:master Feb 29, 2024
19 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants