create systemd dir when use systemd user mode #2373
Conversation
ti-chi-bot
bot
added
the
size/S
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2373 +/- ##
===========================================
- Coverage 55.77% 45.74% -10.03%
===========================================
Files 329 329
Lines 35020 35024 +4
===========================================
- Hits 19531 16020 -3511
- Misses 13145 17052 +3907
+ Partials 2344 1952 -392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ti-chi-bot
bot
added
size/M
pkg/cluster/operation/destroy.go
Outdated
| // Delete systemd directory when use systemd user mode | ||
| if gOpts.SystemdMode == spec.UserMode { | ||
| for host := range instCount { | ||
| if err := DeleteSystemdDir(ctx, host, gOpts); err != nil { |
There was a problem hiding this comment.
don't delete it, user may have some custom service
ti-chi-bot
bot
added
size/S
|
/approve |
|
@Yujie-Xie: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/lgtm |
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: