Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: auto session certs #2374

Merged
merged 6 commits into from
Mar 25, 2024
Merged

cluster: auto session certs #2374

merged 6 commits into from
Mar 25, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Feb 2, 2024

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot requested a review from breezewish February 2, 2024 03:32
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 2, 2024
Signed-off-by: xhe <xw897002528@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 63.10680% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 55.67%. Comparing base (79c584f) to head (d382d73).
Report is 1 commits behind head on master.

❗ Current head d382d73 differs from pull request most recent head ecff4e7. Consider uploading reports for the commit ecff4e7 to get more accurate results

Files Patch % Lines
pkg/cluster/manager/builder.go 63.24% 17 Missing and 8 partials ⚠️
pkg/cluster/spec/tidb.go 56.67% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2374      +/-   ##
==========================================
- Coverage   55.78%   55.67%   -0.11%     
==========================================
  Files         329      329              
  Lines       35024    35100      +76     
==========================================
+ Hits        19537    19541       +4     
- Misses      13143    13208      +65     
- Partials     2344     2351       +7     
Flag Coverage Δ
cluster 45.19% <62.00%> (-0.11%) ⬇️
dm 25.47% <8.00%> (-0.04%) ⬇️
playground 15.30% <8.57%> (-0.03%) ⬇️
tiup 33.60% <ø> (ø)
unittest 22.19% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox marked this pull request as ready for review February 26, 2024 05:04
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@kaaaaaaang kaaaaaaang merged commit f5e6dbf into pingcap:master Mar 25, 2024
18 of 19 checks passed
@kaaaaaaang kaaaaaaang modified the milestones: v1.16.0, v1.15.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants