Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms: fix pdms grafana display #2382

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Mar 12, 2024

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

before
image

after
image

Release notes:

NONE

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from breezewish March 12, 2024 10:15
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 12, 2024

@lhy1024 @rleungx PTAL, thx!

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 12, 2024

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.06%. Comparing base (9e11d0e) to head (cd07a2b).

❗ Current head cd07a2b differs from pull request most recent head e1db0bb. Consider uploading reports for the commit e1db0bb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2382   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files         329      329           
  Lines       35040    35040           
=======================================
  Hits        19644    19644           
  Misses      13058    13058           
  Partials     2338     2338           
Flag Coverage Δ
playground 15.79% <100.00%> (+0.01%) ⬆️
tiup 33.64% <ø> (ø)
unittest 22.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-26 01:57:37.41884204 +0000 UTC m=+1946684.441088428: ☑️ agreed by kaaaaaaang.

@kaaaaaaang kaaaaaaang merged commit ddbbc4d into pingcap:master Mar 26, 2024
6 of 7 checks passed
@HuSharp HuSharp deleted the fix_pdms_grafana branch March 26, 2024 02:01
@kaaaaaaang kaaaaaaang modified the milestones: v1.16.0, v1.15.0 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants