Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prometheus config when scale in #2387

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Yujie-Xie
Copy link
Collaborator

What problem does this PR solve?

#2327
#2375

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack March 21, 2024 03:15
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 55.96%. Comparing base (9e11d0e) to head (684f9d9).

❗ Current head 684f9d9 differs from pull request most recent head e9e296e. Consider uploading reports for the commit e9e296e to get more accurate results

Files Patch % Lines
pkg/cluster/manager/scale_in.go 48.57% 14 Missing and 4 partials ⚠️
pkg/cluster/manager/destroy.go 52.63% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2387      +/-   ##
==========================================
- Coverage   56.07%   55.96%   -0.11%     
==========================================
  Files         329      329              
  Lines       35040    35082      +42     
==========================================
- Hits        19646    19632      -14     
- Misses      13056    13100      +44     
- Partials     2338     2350      +12     
Flag Coverage Δ
cluster 45.20% <50.00%> (-0.12%) ⬇️
dm 25.54% <31.48%> (-0.03%) ⬇️
playground 15.78% <ø> (-0.01%) ⬇️
tiup 33.59% <ø> (-0.05%) ⬇️
unittest 22.20% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yujie-Xie Yujie-Xie merged commit 21e4114 into master Mar 29, 2024
18 of 19 checks passed
@Yujie-Xie Yujie-Xie deleted the update-prometheus-when-scale-in branch March 29, 2024 07:41
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants