Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiflash numa node not working issue #2401

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Apr 9, 2024

What problem does this PR solve?

Fix #2384

What is changed and how it works?

See #2384

Check List

Tests

  • No code
    It seems these codes do not have tests. I don't know how to add a test properly.

Code changes

  • No

Side effects

  • No

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack April 9, 2024 08:26
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 9, 2024
@gengliqi gengliqi changed the title fix tiflash numa node Fix tiflash numa node not working issue Apr 9, 2024
@kaaaaaaang kaaaaaaang added this to the v1.15.1 milestone Apr 9, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

@gengliqi: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang kaaaaaaang merged commit ea64109 into pingcap:master Apr 9, 2024
6 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiFlash numa node does not work
3 participants