Always match the newest store when matching by address #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logically, only the store id identify a store. if normally scale-in a store and scale-out using the same ip:port, then there's will not only one store with the same address. also, this pr fix the tidbSpec initialize which we must make sure initiaize the profile dir first.
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
===========================================
+ Coverage 39.84% 50.54% +10.69%
===========================================
Files 201 219 +18
Lines 14847 15888 +1041
===========================================
+ Hits 5916 8030 +2114
+ Misses 8072 6738 -1334
- Partials 859 1120 +261
Continue to review full report at Codecov.
|
lonng
reviewed
Jul 7, 2020
pkg/cluster/spec/util.go
Outdated
| clusterBaseDir := filepath.Join(profileDir, TiOpsClusterDir) | ||
| clusterSpec := meta.NewSpec(clusterBaseDir) | ||
| return clusterSpec | ||
| tidbSpec = meta.NewSpec(clusterBaseDir) |
There was a problem hiding this comment.
How about putting tidbSpec = meta.NewSpec(clusterBaseDir) into Initialize function directly?
|
@lonng,Thanks for your review. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logically, only the store id identify a store.
if normally scale-in a store and scale-out using the same ip:port,
then there's will not only one store with the same address.
before this pr, only some API will match the newest store, this pr make sure all API match the newest store when matching by address.
also, this pr fix the tidbSpec initialize which we must make sure
initiaize the profile dir first.