Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster service shouldn't use image name for service name. #117

Closed
samir-gandhi opened this issue Apr 9, 2021 · 1 comment · Fixed by #120
Closed

cluster service shouldn't use image name for service name. #117

samir-gandhi opened this issue Apr 9, 2021 · 1 comment · Fixed by #120
Assignees
@tsigle
Labels
bug Something isn't working
Milestone
Release 0.5.2

Comments

@samir-gandhi
Copy link
Contributor

Effect Summary:
If you change the image name, PD/PF clusters will not be created properly.

Cause:
https://github.com/pingidentity/helm-charts/blob/master/charts/ping-devops/templates/pinglib/_service-cluster.tpl
uses pinglib.fullimagename
@samir-gandhi samir-gandhi added the bug Something isn't working label Apr 9, 2021
@samir-gandhi samir-gandhi linked a pull request Apr 9, 2021 that will close this issue
copy _service-cluster.tpl #118
Closed
@samir-gandhi
Copy link
Contributor Author

**this also brings up a good point that we should test with different image names. Taken further, we could identify other common changes and add those to the test suite.

@tsigle tsigle added this to the Release 0.5.2 milestone Apr 13, 2021
@tsigle tsigle self-assigned this Apr 13, 2021
tsigle added a commit that referenced this issue Apr 13, 2021
@tsigle
#117 - Change fullimagename to fullname for cluster service
631f7a7
tsigle added a commit that referenced this issue Apr 13, 2021
@tsigle
#117, #116 - Fixing bug with use of clusterIdentifier and image names
96e1244
@tsigle tsigle mentioned this issue Apr 13, 2021
Merged
@tsigle tsigle linked a pull request Apr 13, 2021 that will close this issue
Release 0.5.2 #120
Merged
tsigle added a commit that referenced this issue Apr 13, 2021
@tsigle
Release 0.5.2 (#120)
9e0b9a0 
* Fix #116 - workload.annotations and fix to serviceAccountName for hashicorp vault

* #117 - Change fullimagename to fullname for cluster service

* #117, #116 - Fixing bug with use of clusterIdentifier and image names

* Prepping for release 0.5.2

* #116 - Support annotations at workload

* #116 - Need to check to see if annotations are defined

* Release 0.5.2 - final checkin
tsigle added a commit that referenced this issue Apr 13, 2021
@tsigle
Release 0.5.2 index.yaml (#123)
3947fff 
* Fix #116 - workload.annotations and fix to serviceAccountName for hashicorp vault

* #117 - Change fullimagename to fullname for cluster service

* #117, #116 - Fixing bug with use of clusterIdentifier and image names

* Prepping for release 0.5.2

* #116 - Support annotations at workload

* #116 - Need to check to see if annotations are defined

* Release 0.5.2 - final checkin

* Release 0.5.2 index.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsigle tsigle

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.5.2
Development

Successfully merging a pull request may close this issue.

Release 0.5.2 pingidentity/helm-charts
copy _service-cluster.tpl pingidentity/helm-charts
2 participants
@tsigle @samir-gandhi