Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When creating configMapRef's, take into account the proper release name to include #62

Closed
tsigle opened this issue Dec 21, 2020 · 0 comments · Fixed by #63
Closed

When creating configMapRef's, take into account the proper release name to include #62

tsigle opened this issue Dec 21, 2020 · 0 comments · Fixed by #63

Comments

@tsigle
Copy link
Contributor

tsigle commented Dec 21, 2020 •
edited

Currently, when a configMapRef is created in the workload it always assuemes a name with a preceding Release.Name.

        envFrom:
        - configMapRef:
            name: {{ $top.Release.Name }}-global-env-vars
            optional: true
        - configMapRef:
            name: {{ $top.Release.Name }}-env-vars
            optional: true

The include should be used to mimic the name that is used when naming the configMapRef and honor the setting of the addReleaseNameToResources value.

name: {{ include "pinglib.fullname" . }}-env-vars
tsigle added a commit that referenced this issue Dec 21, 2020
@tsigle
Release 0.3.8. Resolves issues #56 and #62
e15a380
@tsigle tsigle mentioned this issue Dec 21, 2020
Merged
@tsigle tsigle linked a pull request Dec 21, 2020 that will close this issue
Release 0.3.8. Resolves issues #56 and #62 #63
Merged
tsigle added a commit that referenced this issue Dec 21, 2020
@tsigle
Release 0.3.8. Resolves issues #56 and #62 (#63)
61fca8d 
* Release 0.3.8.  Resolves issues #56 and #62

* added missing colons:

* typo
tsigle added a commit that referenced this issue Dec 21, 2020
@tsigle
Rel0.3.8 (#64)
66fc840 
* Release 0.3.8.  Resolves issues #56 and #62

* added missing colons:

* typo

* release 0.3.8 index.yaml
tsigle added a commit that referenced this issue Dec 22, 2020
@tsigle
Fix some doc typos (#65)
7a31d8c 
* Release 0.3.8.  Resolves issues #56 and #62

* added missing colons:

* typo

* release 0.3.8 index.yaml

* Fix Kubernetes typo
tsigle added a commit that referenced this issue Dec 22, 2020
@tsigle
Fix doc typos (#66)
330c92f 
* Release 0.3.8.  Resolves issues #56 and #62

* added missing colons:

* typo

* release 0.3.8 index.yaml

* Fix Kubernetes typo

* Fix doc typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.3.8. Resolves issues #56 and #62 pingidentity/helm-charts
1 participant
@tsigle