Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDI-1642: Update PingCTL with Internal Feedback #107

Merged
merged 1 commit into from
Apr 3, 2024
Merged

PDI-1642: Update PingCTL with Internal Feedback #107

merged 1 commit into from
Apr 3, 2024

Conversation

erikostien-pingidentity
Copy link
Contributor

  • Check entire export directory. If there is anything present, abort the export of all services. This avoids mismatching environment exports over multiple export commands from the customer.
  • Small error message update for export.go.

@erikostien-pingidentity
PDI-1642: Update PingCTL with Internal Feedback
7509a54 
- Check entire export directory. If there is anything present,
abort the export of all services. This avoids mismatching environment
exports over multiple export commands from the customer.
- Small error message update for export.go.
@erikostien-pingidentity erikostien-pingidentity requested a review from a team as a code owner April 3, 2024 16:26
henryrecker-pingidentity
henryrecker-pingidentity reviewed Apr 3, 2024
View reviewed changes
Copy link

@henryrecker-pingidentity henryrecker-pingidentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the directory check happen before or after all the API calls?

henryrecker-pingidentity
henryrecker-pingidentity approved these changes Apr 3, 2024
View reviewed changes
Copy link

@henryrecker-pingidentity henryrecker-pingidentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking through it looks like it does check the directory before the main API calls - I was confusing connector.ExportableResource with the import blocks.

@erikostien-pingidentity erikostien-pingidentity merged commit c990995 into go-cli Apr 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryrecker-pingidentity henryrecker-pingidentity henryrecker-pingidentity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikostien-pingidentity @henryrecker-pingidentity