Added pingone_application export resource #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PingDavidR
commented
Mar 15, 2024
PingDavidR
commented
- closes PDI-1541
There was a problem hiding this comment.
FYI we are waiting to merge these until the repo restructure pull request #71 is merged, so that we keep the git history clear.
internal/connector/pingone/resources/sso/pingone_application.go
Outdated
Show resolved
Hide resolved
| "fmt" | ||
|
|
||
| "github.com/pingidentity/pingctl/internal/connector" | ||
| pingoneresourcescommon "github.com/pingidentity/pingctl/internal/connector/pingone/resources/common" |
There was a problem hiding this comment.
It doesn't look like this alias is necessary
There was a problem hiding this comment.
so, if I remove the alias, what does the call on line 35 become?
There was a problem hiding this comment.
Just "common.[etc.]", since that is the non-aliased package name
|
Just need to merge in the latest |
henryrecker-pingidentity
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.