Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in FilterParser #13

Open
fhanik opened this issue Mar 1, 2017 · 2 comments
Open

Bug in FilterParser #13

fhanik opened this issue Mar 1, 2017 · 2 comments

Comments

@fhanik
Copy link

fhanik commented Mar 1, 2017

9f1cf2d#diff-11245e1bab9fb9ac717dff7bf9c44793R377

When this commit was introduced, a SCIMFilter object will always return true for quoteFilterValue even if the value was not quoted.

For example

myattribute = "quoted-value" and myotherattribute = 0

This is a valid SCIM filter. But the above commit states that myotherattribute is a quoted value, but it never was.

The refactor treats everything as a String, and we no longer have a way to distinguish numerical values.

@richardcardona
Copy link
Contributor

Thanks for reporting this issue, I've created an internal JIRA issue to track the concern. I can confirm the issue results from changes made to the FilterParser#readValue method. There is no estimated time for resolution as the issue needs to be reviewed and prioritized.

@richardcardona
Copy link
Contributor

c66701f

The above commit should resolve the regression you encountered. If you can test with the master branch and confirm the fix, it can be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants