Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify client extension for working with not-quite-compliant servers #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hauntingEcho
Copy link

expand buildRequest and toScimException access from package-only to protected, and remove final modifier from builders. This allows easier wrapping for interaction with not-quite-compliant scim2 implementations

…rotected, remove final modifier from builders. This allows easier wrapping for interaction with not-quite-compliant scim2 implementations
@samkeeleyong
Copy link

Is there any reason this hasn't been merged? I'm also having trouble integrating with not-quite-compliant servers so i needed to create my own "ScimService" that's partly copy pasted from the sdk.

@hauntingEcho
Copy link
Author

@samkeeleyong AFAICT they haven't done the legal legwork to accept contributions (e.g. relicensing agreement), so they need to either do that or rewrite similar changes themselves:

Ping Identity does not accept third-party code submissions, such as pull requests.: https://github.com/pingidentity/scim2/blob/master/CONTRIBUTING.md

I'm happy to license this PR globally under the WTFPLv2 with no-warranty clause, which should be fine for your needs and whatever form Ping will eventually want:

This PR is free software. It comes without any warranty, to
the extent permitted by applicable law. You can redistribute it
and/or modify it under the terms of the Do What The Fuck You Want
To Public License, Version 2, as published by Sam Hocevar. See
http://www.wtfpl.net/ for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants