Remove usages of deprecated Jackson APIs #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackson's ISO8601Utils and ISO8601DateFormat classes were deprecated in version Jackson 2.9. To ensure that future Jackson upgrades go smoothly, all usages of these classes were removed from the SCIM 2 SDK (with the exception of the ScimDateFormat class, which will be removed in a separate commit). The SCIM 2 dateTime type follows the xsd:dateType format specified by the W3C XML Schema standard, so all SCIM 2 dateTime handling is now delegated to javax.xml.bind.DatatypeConverter via the new DateTimeUtils class.
…AP_VALUES The existing use of setSerializationInclusion(Include.NON_NULL) appears to accomplish the same goal of not serializing null map values. Added a unit test to confirm this.
* Provide explicit jaxb-api dependency, as this is no longer provided with the JRE/JDK. * Update the Jersey version to 2.28. (Note that Jersey components are only used by the unit tests.) * Update the maven-javadoc-plugin version to 3.1.0. This rectifies an error reported by the plugin: "Error fetching link: .../package-list"
braveulysses
changed the title
Xenial's Maven was unable to download dependencies, so trying Trusty.
This is an attempt to handle a failure in ETagTestCase that only occurs in the Travis CI environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This set of changes removes the SCIM 2 SDK's usages of deprecated Jackson APIs, particularly dateTime data type handling that relies on Jackson's ISO8601-related classes. The SCIM 2 dateTime type follows the xsd:dateType format specified by the W3C XML Schema standard, so all SCIM 2 dateTime handling is now delegated to javax.xml.bind.DatatypeConverter via a new DateTimeUtils
class. Because javax.xml is not bundled with recent versions of the JDK, javax.xml.bind:jaxb-api was added to scim2-sdk-common as a dependency.
The ScimDateFormat class was updated with alternatives to using it now that it is deprecated. This class will be removed in the future — probably when a future Jackson upgrade removes its superclass.
This also includes changes to ensure that the project builds without errors on Java 11.
Does this close any currently open issues?
No, but this is related to issue #120.