Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new data source pingone_roles and extend pingone_role data source schema #599

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

patrickcping
Copy link
Collaborator

@patrickcping patrickcping commented Oct 23, 2023

Change Description

  • data-source/pingone_role: Now supports read-only attributes applicable_to and permissions.
  • data-source/pingone_role: Now supports the ability to look up role data by ID.
  • New data source: pingone_roles

Testing Results

Testing Shell Command

TF_ACC=1 go test -v -timeout 500s -run ^TestAccRoleDataSource_ github.com/pingidentity/terraform-provider-pingone/internal/service/base && TF_ACC=1 go test -v -timeout 500s -run ^TestAccRolesDataSource_ github.com/pingidentity/terraform-provider-pingone/internal/service/base

Testing Results

=== RUN   TestAccRoleDataSource_ByNameFull
=== PAUSE TestAccRoleDataSource_ByNameFull
=== RUN   TestAccRoleDataSource_ByIdFull
=== PAUSE TestAccRoleDataSource_ByIdFull
=== RUN   TestAccRoleDataSource_NotFound
=== PAUSE TestAccRoleDataSource_NotFound
=== CONT  TestAccRoleDataSource_ByNameFull
=== CONT  TestAccRoleDataSource_NotFound
=== CONT  TestAccRoleDataSource_ByIdFull
--- PASS: TestAccRoleDataSource_NotFound (0.31s)
--- PASS: TestAccRoleDataSource_ByIdFull (5.22s)
--- PASS: TestAccRoleDataSource_ByNameFull (35.65s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/base        36.288s
=== RUN   TestAccRolesDataSource_All
=== PAUSE TestAccRolesDataSource_All
=== CONT  TestAccRolesDataSource_All
--- PASS: TestAccRolesDataSource_All (4.10s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/base        4.870s

@patrickcping patrickcping added type/enhancement New feature or request service/base PingOne Platform status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK labels Oct 23, 2023
@patrickcping patrickcping added this to the v0.23.0 milestone Oct 23, 2023
@patrickcping patrickcping self-assigned this Oct 23, 2023
@patrickcping patrickcping linked an issue Oct 23, 2023 that may be closed by this pull request
@patrickcping patrickcping changed the title 563 support new data source pingone roles Support new data source pingone_roles and extend pingone_role data source schema Oct 23, 2023
@patrickcping patrickcping marked this pull request as ready for review October 31, 2023 12:29
@patrickcping patrickcping removed the status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK label Nov 1, 2023
@patrickcping patrickcping merged commit feb64eb into main Nov 1, 2023
23 checks passed
@patrickcping patrickcping deleted the 563-support-new-data-source-pingone_roles branch November 1, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/base PingOne Platform type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new data source pingone_roles
1 participant