Create pulse funcition #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now Pingo supports GrovePI Board. |
|
@gfth4x07, thanks for your time. Please, fix the flake8 warnings. 0.45s$ flake8 --ignore=E501 pingo
pingo/rpi/__init__.py:4:34: W292 no newline at end of file
pingo/rpi/grove.py:11:13: F401 'grovepi' imported but unused
pingo/rpi/grove.py:54:67: E226 missing whitespace around arithmetic operator
pingo/rpi/grove.py:66:52: E226 missing whitespace around arithmetic operatorI will point them in the comments... |
|
I think it's better import grovepi as grovepi. The libraries name is grovepi why not use this name? |
|
@gfth4x07 ok... Just add a dirty fix: import grovepi as grovepi # noqa |
Vido
added a commit
that referenced
this pull request
Jul 3, 2015
Thanks to @gfth4x07, now Pingo has GrovePi.
|
Thanks to @gfth4x07, now Pingo has GrovePi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a function to pulse a pin. This function will take easy the serial communication and write in a Shift-Register.
I tested in a Raspberry Pi 2 B and it's works.