Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better air mass ratio model? #109

Open
aqreed opened this issue Aug 7, 2019 · 1 comment
Open

better air mass ratio model? #109

aqreed opened this issue Aug 7, 2019 · 1 comment

Comments

@aqreed
Copy link

aqreed commented Aug 7, 2019

Hello @pingswept ,

I have been working lately on my own solar irradiation model, and I believe this air mass model based on Kasten & Young (1989) or this one, based on Young (1994), might be interesting for this package too.

If it is interesting for you indeed, I can open a pull request, provided it does not break anything at testing.

BR,
A.

@aqreed aqreed changed the title better Air Mass model? better air mass ratio model? Aug 7, 2019
@pingswept
Copy link
Owner

If it doesn't break the validation code we've got, sounds great. I would be hesitant to include other models if it breaks our validation, and we have no better way of validating the new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants