Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elastic): rename ssl options to tls #181

Merged
merged 1 commit into from Dec 8, 2023
Merged

fix(elastic): rename ssl options to tls #181

merged 1 commit into from Dec 8, 2023

Conversation

neverovski
Copy link
Contributor

@neverovski neverovski commented Nov 28, 2023 •
edited

#180 In version 8 renamed the ssl option to tls.
This commit adjusts the code to reflect this change, ensuring compatibility with Elasticsearch 8.

Rename ssl option to tls
Link to documentation

@neverovski neverovski mentioned this pull request Nov 28, 2023
Closed
@neverovski
Copy link
Contributor Author

neverovski commented Nov 28, 2023 •
edited

I would update package elasticsearch-js to last version, because last version supported Node.js 16 and more

@neverovski neverovski changed the title fix: use TLS or SSL depending on ES version fix(elastic): rename ssl options to tls Nov 28, 2023
@neverovski
Copy link
Contributor Author

@mcollina check PR

mcollina
mcollina approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsumners
jsumners reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a semver major change.

@neverovski
Copy link
Contributor Author

@mcollina and @jsumners Hi guys, how about this PR?

pino-elasticsearch v7.0.0 is broken, https connection doesn't work. After updating the package @elastic/elasticsearch to version 8.0.0, because in version 8 renamed the ssl option to tls - Rename ssl option to tls

@jsumners
Copy link
Member

jsumners commented Dec 8, 2023

Hi guys, how about this PR?

I would say that this PR should be backward compatible so that it is easier to merge and release. But I really don't have any strong opinion on the module in general. I was just pointing out that the current change will require publishing a major.

@neverovski
Copy link
Contributor Author

neverovski commented Dec 8, 2023 •
edited

Hi guys, how about this PR?

I would say that this PR should be backward compatible so that it is easier to merge and release. But I really don't have any strong opinion on the module in general. I was just pointing out that the current change will require publishing a major.

I can update and use two params (ssl and tls) and mark ssl as deprecated

@mcollina
Copy link
Member

mcollina commented Dec 8, 2023

I have no issue in shipping a major. This sits in the 300+ notification queue (currently on mobile).

@jsumners jsumners merged commit 5617705 into pinojs:master Dec 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neverovski @jsumners @mcollina