Support regex path matching for autoLogging.ignorePaths option #100
Conversation
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "pino-http", | |||
| "version": "5.1.0", | |||
| "version": "5.2.0", | |||
| shouldLogSuccess = !autoLoggingIgnorePaths.includes(url.pathname) | ||
| shouldLogSuccess = !autoLoggingIgnorePaths.find(ignorePath => { | ||
| return new RegExp(ignorePath).test(url.pathname) | ||
| }) |
There was a problem hiding this comment.
We should not be generating a new regexp for strings that are anot already regexp.
There was a problem hiding this comment.
@mcollina let me know if you prefer some other approach. I thought this would work as well and be a bit more explicit.
|
@jsumners @davidmarkclements wdyt? |
There was a problem hiding this comment.
For reference, we initially discussed regexes being used in this path at #77 (comment)
I think the test for if the item is a regex instance is a good compromise. Some sort of find-my-way-like test would probably be better, but that's just a guess.
|
ping: @davidmarkclements |
|
Is there any intention of merging this? I can always target a branch to get this functionality, but it would be a lot cleaner to just be able to use the base package. I'm not clear on the governance of this project, does @davidmarkclements need to +1 it, because it's been many months waiting on him to check in. |
|
published as 5.3.0 sorry for the delay everyone |
I was using the latest version and have a use-case where I want to ignore a dynamic range of paths that can change over time. In order to support this I thought that adding RegExp support to the ignoring mechanism might be an option.
Let me know what you think. Thanks for taking a look.