Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log requests aborted during payload processing #219

Merged

Conversation

jonathansamines
Copy link
Contributor

Client requests aborted during payload processing are now logged as request aborted instead of being silently ignored. Continues the work on #117 and #123. Tests do not rely on timers, and are based on hapi's tests

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails on Node v17 and v18 as the resolution of localhost changed.

@jonathansamines
Copy link
Contributor Author

Fails on Node v17 and v18 as the resolution of localhost changed.

Updated test to always bind the host and port. Hopefully it will pass this time.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants