Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing space in error message #99

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Remove trailing space in error message #99

merged 2 commits into from
Apr 24, 2020

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Apr 23, 2020 •
edited

Currently causing the tests to fail in express-pino-logger:

  not ok message is set
    --- wanted                  
    +++ found                   
    -"request errored"          
    +"request errored "

@LinusU LinusU mentioned this pull request Apr 23, 2020
Closed
mcollina
mcollina reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if this was covered by a test.

@LinusU
Copy link
Contributor Author

LinusU commented Apr 24, 2020

@mcollina done 👍

mcollina
mcollina approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 251a1be into pinojs:master Apr 24, 2020
@LinusU LinusU deleted the patch-1 branch April 26, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LinusU @mcollina