fix: adds support for printing number and boolean messageKey value ty…

…pe (#434) * fix: adds support for printing number and boolean messageKey value type closes: Pino Pretty does not output numbers but only strings. #433 * Update test/basic.test.js Co-authored-by: James Sumners <james@sumners.email> * Update test/basic.test.js Co-authored-by: James Sumners <james@sumners.email> * Update test/basic.test.js Co-authored-by: James Sumners <james@sumners.email> * fix: checks for undefined specifically instead of falsey values --------- Co-authored-by: James Sumners <james@sumners.email>
pinojs · Jul 4, 2023 · c32de73 · c32de73
1 parent 5d64b47
commit c32de73
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -162,7 +162,7 @@ function prettyFactory (options) {
       line += ':'
     }
 
-    if (prettifiedMessage) {
+    if (prettifiedMessage !== undefined) {
       if (line.length > 0) {
         line = `${line} ${prettifiedMessage}`
       } else {
@@ -186,7 +186,7 @@ function prettyFactory (options) {
       if (singleLine) line += EOL
       line += prettifiedErrorLog
     } else if (!hideObject) {
-      const skipKeys = [messageKey, levelKey, timestampKey].filter(key => typeof log[key] === 'string' || typeof log[key] === 'number')
+      const skipKeys = [messageKey, levelKey, timestampKey].filter(key => typeof log[key] === 'string' || typeof log[key] === 'number' || typeof log[key] === 'boolean')
       const prettifiedObject = prettifyObject({
         input: log,
         skipKeys,

diff --git a/lib/utils.js b/lib/utils.js
@@ -280,7 +280,7 @@ function prettifyMessage ({ log, messageFormat, messageKey = MESSAGE_KEY, colori
     return colorizer.message(msg)
   }
   if (messageKey in log === false) return undefined
-  if (typeof log[messageKey] !== 'string') return undefined
+  if (typeof log[messageKey] !== 'string' && typeof log[messageKey] !== 'number' && typeof log[messageKey] !== 'boolean') return undefined
   return colorizer.message(log[messageKey])
 }
 

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -118,6 +118,70 @@ test('basic prettifier tests', (t) => {
     log.info('foo')
   })
 
+  t.test('can print message key value when its a string', (t) => {
+    t.plan(1)
+    const pretty = prettyFactory()
+    const log = pino({}, new Writable({
+      write (chunk, enc, cb) {
+        const formatted = pretty(chunk.toString())
+        t.equal(
+          formatted,
+          `[${formattedEpoch}] INFO (${pid}): baz\n`
+        )
+        cb()
+      }
+    }))
+    log.info('baz')
+  })
+
+  t.test('can print message key value when its a number', (t) => {
+    t.plan(1)
+    const pretty = prettyFactory()
+    const log = pino({}, new Writable({
+      write (chunk, enc, cb) {
+        const formatted = pretty(chunk.toString())
+        t.equal(
+          formatted,
+          `[${formattedEpoch}] INFO (${pid}): 42\n`
+        )
+        cb()
+      }
+    }))
+    log.info(42)
+  })
+
+  t.test('can print message key value when its a Number(0)', (t) => {
+    t.plan(1)
+    const pretty = prettyFactory()
+    const log = pino({}, new Writable({
+      write (chunk, enc, cb) {
+        const formatted = pretty(chunk.toString())
+        t.equal(
+          formatted,
+          `[${formattedEpoch}] INFO (${pid}): 0\n`
+        )
+        cb()
+      }
+    }))
+    log.info(0)
+  })
+
+  t.test('can print message key value when its a boolean', (t) => {
+    t.plan(1)
+    const pretty = prettyFactory()
+    const log = pino({}, new Writable({
+      write (chunk, enc, cb) {
+        const formatted = pretty(chunk.toString())
+        t.equal(
+          formatted,
+          `[${formattedEpoch}] INFO (${pid}): true\n`
+        )
+        cb()
+      }
+    }))
+    log.info(true)
+  })
+
   t.test('can use different message keys', (t) => {
     t.plan(1)
     const pretty = prettyFactory({ messageKey: 'bar' })