Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests platform independent #199

Merged
merged 1 commit into from Jun 20, 2021
Merged

Conversation

osher
Copy link
Contributor

@osher osher commented Jun 20, 2021

Cloned a fork, installed dependencies and ran tests on master as a 1st step to work on a PR.

However, alas - it failed tests out of the box because the tests assume a \n line ending where the windows host I was working on uses \r\n.

@osher
Copy link
Contributor Author

osher commented Jun 20, 2021

Now it passes the tests but still fails the coverage on windows, I spent time on it but did not figure why.

I hope this contribution can be accepted. Despite it's half a way - the other half may be a different issue

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Jun 20, 2021

Pull Request Test Coverage Report for Build 953950823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 905400873: 0.0%
Covered Lines: 278
Relevant Lines: 278

💛 - Coveralls

@mcollina mcollina merged commit 5c34ccd into pinojs:master Jun 20, 2021
@mcollina
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants