Fix 'ignore' for keys containing key delimiter #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1044509237
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1045049814
💛 - Coveralls |
kibertoad
reviewed
Jul 19, 2021
lib/utils.js
Outdated
| */ | ||
| function deleteLogProperty (log, property) { | ||
| const props = property.split('.') | ||
| const props = property.match(/([^\\.]|\\\.)+/g).map((e) => e.split('\\.').join('.')) |
There was a problem hiding this comment.
how expensive is this operation?
There was a problem hiding this comment.
https://jsbench.me/tqkrafwdkf/1
I just performed some benchmarks, this implementation is ~81% slower compared to just a split.
There might be quite a hit on performance with this change, however, this can be improved if we split the key using a loop. Benchmark shows that it is ~36% slower compared to just a split.
Will be pushing the improved version shortly for review.
|
Thanks very much for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue reported by @acidoxee in #132 (comment) just before the issue was closed.
This commit attempts to overcome the limitation by allowing the user to escape the dot character used as a delimiter.
The method used is to split the key by the dot delimiter ignoring any escaped dots, followed by replacing all occurrences of the escaped dots. Alternatively, it is possible to use a negative lookbehind regex for the split, but might not be supported on all browsers.
Thanks!