Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not treat errors without a stack as errors #30

Merged
merged 1 commit into from Sep 3, 2018
Merged

do not treat errors without a stack as errors #30

merged 1 commit into from Sep 3, 2018

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Sep 3, 2018

Fixes #29

@mcollina
Copy link
Member Author

mcollina commented Sep 3, 2018

cc @OlivierCuyp

@coveralls
Copy link

coveralls commented Sep 3, 2018 •
edited

Pull Request Test Coverage Report for Build 79

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.674%
Totals Coverage Status
Change from base Build 74: 0.0%
Covered Lines: 131
Relevant Lines: 131
💛 - Coveralls

jsumners
jsumners approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit a02a9a1 into master Sep 3, 2018
@mcollina mcollina deleted the fix-apollo branch September 3, 2018 12:27
@OlivierCuyp
Copy link

@mcollina I was testing it with npm link, it works like a charm (you merged in the mean time).
Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcollina @coveralls @OlivierCuyp @jsumners