resolves #85 introduce onBeforeDataWrite callback #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogravity
commented
Aug 4, 2022
| @@ -84,6 +86,10 @@ module.exports = function factory (userOptions) { | |||
| if (socket.writableEnded) { | |||
| handleSocketWriteError(new Error('This socket has been ended by the other party'), data, encoding) | |||
| } else { | |||
| if (options.onBeforeDataWrite) { | |||
| data = options.onBeforeDataWrite(data) | |||
There was a problem hiding this comment.
Not sure if this is bad practice here, but I've overwritten the existing data value to spare memory overhead from having to create another copy of the data.
If you're not into that, I can do something of the following:
let newData
if (options.onBeforeDataWrite) {
newData = options.onBeforeDataWrite(data)
}
socket.write(newData | data, ...)
jsumners
requested changes
Aug 4, 2022
|
Addressed feedback.
|
jsumners
approved these changes
Aug 4, 2022
|
why did you close this? |
|
I didn't. Looks like it auto-closes if I remove my forked repo. However, you should still be able to merge it? If you're unable to, I can re-fork and re-create the PR by creating a patch from this one and applying it. |
|
Odd, the Github app gives status saying it's mergable but the web UI completely removes it. Apologies, will re-fork and re-submit. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm introducing a callback called
onBeforeDataWritewith a signature(data: Buffer) => Bufferthat allows manipulation of the data before it is written out to the socket.This resolves #85.