The function check does some internal assertions using the assert function it receives as parameter

[gerardo-lima-moonfare]

The enclosed function check uses the same assert function it receives as parameter to do some internal checks on time, pid and hostname. It is unnecessary to use default assert function (deepStrictEqual) to check on these values and this behaviour also makes it hard to create assessments on properties -- ie: when chunkCopy must contain some property foo, we also have to account for the time, pid and hostname.

pino-test/pino-test.js

Line 38 in c22d2ab

function check (chunk, expected, assert) {

My suggestion is to to use standard strictEqual on the internal checks and only use the assert function parameter on the payload (chunkCopy), itself. This is a suggestion of implementation:

function check (chunk, expected, assert) {
  const { time, pid, hostname, ...chunkCopy } = chunk

  // internal assertions (*)
  nodeAssert.strictEqual(new Date(time) <= new Date(), true, 'time is greater than Date.now()')
  nodeAssert.strictEqual(pid, process.pid)
  nodeAssert.strictEqual(hostname, os.hostname())

  // "consumer" assertion
  assert(chunkCopy, expected)
}

PS: on a side note, I'm not sure whether it's actually useful to run these internal assertions each time a consumer asserts on their logs, but maybe I'm missing something here

[mcollina]

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.