Replacing var with let/const, somewhere left var because scope, somew…

…here left var because for + resolved all standard issues
pinojs · Jan 13, 2021 · 2fd82b7 · 2fd82b7
1 parent 40fa7f6
commit 2fd82b7
Show file tree

Hide file tree

Showing 64 changed files with 387 additions and 233 deletions.
diff --git a/benchmarks/basic.bench.js b/benchmarks/basic.bench.js
@@ -43,48 +43,56 @@ const chill = winston.createLogger({
 
 const run = bench([
   function benchBunyan (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       blog.info('hello world')
     }
     setImmediate(cb)
   },
   function benchWinston (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       chill.log('info', 'hello world')
     }
     setImmediate(cb)
   },
   function benchBole (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       bole.info('hello world')
     }
     setImmediate(cb)
   },
   function benchDebug (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       dlog('hello world')
     }
     setImmediate(cb)
   },
   function benchLogLevel (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       loglevel.info('hello world')
     }
     setImmediate(cb)
   },
   function benchPino (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogDest.info('hello world')
     }
     setImmediate(cb)
   },
   function benchPinoAsync (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogAsync.info('hello world')
     }
     setImmediate(cb)
   },
   function benchPinoNodeStream (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogNodeStream.info('hello world')
     }

diff --git a/benchmarks/child-child.bench.js b/benchmarks/child-child.bench.js
@@ -24,24 +24,28 @@ const blog = bunyan.createLogger({
 
 const run = bench([
   function benchBunyanChildChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       blog.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoChildChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogDest.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoAsyncChildChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogAsync.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoNodeStreamChildChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogNodeStream.info({ hello: 'world' })
     }

diff --git a/benchmarks/child-creation.bench.js b/benchmarks/child-creation.bench.js
@@ -27,35 +27,40 @@ require('bole').output({
 
 const run = bench([
   function benchBunyanCreation (cb) {
-    var child = blog.child({ a: 'property' })
+    const child = blog.child({ a: 'property' })
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchBoleCreation (cb) {
-    var child = bole('child')
+    const child = bole('child')
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoCreation (cb) {
-    var child = plogDest.child({ a: 'property' })
+    const child = plogDest.child({ a: 'property' })
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoAsyncCreation (cb) {
-    var child = plogAsync.child({ a: 'property' })
+    const child = plogAsync.child({ a: 'property' })
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoNodeStreamCreation (cb) {
-    var child = plogNodeStream.child({ a: 'property' })
+    const child = plogNodeStream.child({ a: 'property' })
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.info({ hello: 'world' })
     }

diff --git a/benchmarks/child.bench.js b/benchmarks/child.bench.js
@@ -28,30 +28,35 @@ require('bole').output({
 
 const run = bench([
   function benchBunyanChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       blog.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchBoleChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       bole.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogDest.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoAssyncChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogAsync.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoNodeStreamChild (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogNodeStream.info({ hello: 'world' })
     }

diff --git a/benchmarks/deep-object.bench.js b/benchmarks/deep-object.bench.js
@@ -42,42 +42,49 @@ const chill = winston.createLogger({
 
 const run = bench([
   function benchBunyanDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       blog.info(deep)
     }
     setImmediate(cb)
   },
   function benchWinstonDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       chill.log(deep)
     }
     setImmediate(cb)
   },
   function benchBoleDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       bole.info(deep)
     }
     setImmediate(cb)
   },
   function benchLogLevelDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       loglevel.info(deep)
     }
     setImmediate(cb)
   },
   function benchPinoDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogDest.info(deep)
     }
     setImmediate(cb)
   },
   function benchPinoAsyncDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogAsync.info(deep)
     }
     setImmediate(cb)
   },
   function benchPinoNodeStreamDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogNodeStream.info(deep)
     }

diff --git a/benchmarks/formatters.bench.js b/benchmarks/formatters.bench.js
@@ -34,12 +34,14 @@ const max = 10
 
 const run = bench([
   function benchPinoNoFormatters (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       pinoNoFormatters.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoFormatters (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       pinoFormatters.info({ hello: 'world' })
     }

diff --git a/benchmarks/internal/custom-levels.js b/benchmarks/internal/custom-levels.js
@@ -17,37 +17,43 @@ const max = 100
 
 const run = bench([
   function benchPinoNoCustomLevel (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       base.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoCustomLevel (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       baseCl.foo({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchChildNoCustomLevel (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.info({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoChildCustomLevel (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       childCl.foo({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoChildInheritedCustomLevel (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       childOfBaseCl.foo({ hello: 'world' })
     }
     setImmediate(cb)
   },
   function benchPinoChildCreation (cb) {
     const child = base.child({})
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.info({ hello: 'world' })
     }
@@ -57,6 +63,7 @@ const run = bench([
     const child = base.child({
       customLevels: { foo: 31 }
     })
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       child.foo({ hello: 'world' })
     }

diff --git a/benchmarks/internal/just-pino-heavy.bench.js b/benchmarks/internal/just-pino-heavy.bench.js
@@ -18,54 +18,63 @@ const max = 10
 
 const run = bench([
   function benchPinoLongString (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plog.info(longStr)
     }
     setImmediate(cb)
   },
   function benchPinoDestLongString (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogDest.info(longStr)
     }
     setImmediate(cb)
   },
   function benchPinoAsyncLongString (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogAsync.info(longStr)
     }
     setImmediate(cb)
   },
   function benchPinoDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plog.info(deep)
     }
     setImmediate(cb)
   },
   function benchPinoDestDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogDest.info(deep)
     }
     setImmediate(cb)
   },
   function benchPinoAsyncDeepObj (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogAsync.info(deep)
     }
     setImmediate(cb)
   },
   function benchPinoInterpolateDeep (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plog.info('hello %j', deep)
     }
     setImmediate(cb)
   },
   function benchPinoDestInterpolateDeep (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogDest.info('hello %j', deep)
     }
     setImmediate(cb)
   },
   function benchPinoAsyncInterpolateDeep (cb) {
+    /* eslint no-var: off */
     for (var i = 0; i < max; i++) {
       plogAsync.info('hello %j', deep)
     }