Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update typings #1073

Merged
merged 2 commits into from Jul 21, 2021
Merged

refactor: update typings #1073

merged 2 commits into from Jul 21, 2021

Conversation

climba03003
Copy link
Contributor

@climba03003 climba03003 commented Jul 21, 2021

Update typings in favor of #1059 and #1067

level?: Level | string;
serializers?: { [key: string]: SerializerFn };
[key: string]: any;
customLevels?: { [key: string]: number };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know if it is intended not to include both customLevels and formatters, as it do not support in broswer.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from kibertoad July 21, 2021 21:07
@mcollina mcollina merged commit 01a8633 into pinojs:master Jul 21, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants