Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Moves pino-pretty from devDependencies to dependencies #1103

Closed
wants to merge 1 commit into from
Closed

fix: Moves pino-pretty from devDependencies to dependencies #1103

wants to merge 1 commit into from

Conversation

spa5k
Copy link

@spa5k spa5k commented Aug 27, 2021

Fixes - #1102

More explanation on the issue.

Copy link
Contributor

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pino-pretty is not mandatory when using pino. So to me this change doesn't make sense since some users will end up installing things that they won't use.

@kibertoad
Copy link
Contributor

I think better change would be a more helpful error message when trying to use pino-pretty when one is not installed, instructing user to add it as a dependency.

@jsumners
Copy link
Member

Thank you for taking the time to submit a contribution, but we do not include pino-pretty as a hard dependency for a reason. We do not promote prettification in production and our docs are very clear that you must install the module on your own if you want in-process prettification.

@jsumners jsumners closed this Aug 28, 2021
@spa5k
Copy link
Author

spa5k commented Aug 28, 2021

Can we add it to peerDependenciesMeta then?

"peerDependenciesMeta": {
  "pino-pretty": {
    "optional": true
  }
}

@jsumners

@jsumners
Copy link
Member

Can we add it to peerDependenciesMeta then?

"peerDependenciesMeta": {
  "pino-pretty": {
    "optional": true
  }
}

@jsumners

Please follow #1106.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants