[v6.x] set max depth and edge limit #1120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
approved these changes
Sep 8, 2021
jsumners
approved these changes
Sep 8, 2021
simoneb
approved these changes
Sep 9, 2021
|
Is this waiting for #1169 or could we merge and release already? |
|
@marcbachmann I think they can be considered independent. The only thing we should try to get some consistency on is the default limits, which are different between the 2 PRs. In #1169 we set these because they are fixing the original issue #990 but I'm not 100% sure they are sensible defaults. |
|
I also think |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #990
We might want to expose this as config values.
(Note that we cannot forward-port this change to v7.x, as we switched the serialization engine)