Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated options in pino.child() #1124

Merged
merged 2 commits into from Sep 10, 2021
Merged

Removed deprecated options in pino.child() #1124

merged 2 commits into from Sep 10, 2021

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Sep 9, 2021

No description provided.

@mcollina mcollina changed the title removed deprecation warning during is-level-enabled test Removed deprecated options in pino.child() Sep 10, 2021
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must make sure to highlight this in the release notes.

@kibertoad
Copy link
Contributor

@mcollina Should bindings be completely dropped from typings, or there are still cases when they are used?

@mcollina mcollina added this to the v7.0.0 milestone Sep 10, 2021
@mcollina
Copy link
Member Author

I think the typings are already correct.

@mcollina mcollina merged commit a0010f3 into master Sep 10, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants