compatibility fix #1254
compatibility fix #1254
Conversation
This will fix some incompatibility issues with some node.js use-cases by handling over the module loading to require. This patch is dependent also to the patches I made with the thread-stream and real-require.
| @@ -13,6 +13,12 @@ module.exports = async function ({ targets }) { | |||
| targets = await Promise.all(targets.map(async (t) => { | |||
| let fn | |||
| try { | |||
| if(typeof process !== "undefined"){ | |||
There was a problem hiding this comment.
Please follow the linting rules of this project.
| @@ -13,6 +13,12 @@ module.exports = async function ({ targets }) { | |||
| targets = await Promise.all(targets.map(async (t) => { | |||
| let fn | |||
| try { | |||
| if(typeof process !== "undefined"){ | |||
| //reuse the error code. | |||
There was a problem hiding this comment.
What is this comment referencing?
There was a problem hiding this comment.
I am sorry. I meant that I reused the error code for the condition to match in the if statement catch clause.
| @@ -13,6 +13,12 @@ module.exports = async function ({ targets }) { | |||
| targets = await Promise.all(targets.map(async (t) => { | |||
| let fn | |||
| try { | |||
| if(typeof process !== "undefined"){ | |||
| //reuse the error code. | |||
| const err = new Error() | |||
There was a problem hiding this comment.
| const err = new Error() | |
| const err = Error() |
Also, an appropriate message should be passed to the constructor.
There was a problem hiding this comment.
We should not emit Node core error codes
| if(typeof process !== "undefined"){ | ||
| //reuse the error code. | ||
| const err = new Error() | ||
| err.code = 'ERR_MODULE_NOT_FOUND'; |
There was a problem hiding this comment.
Is this code appropriate for the condition?
|
I was long away from from the project where I used this. I remembered it as someone proposed a better fix. I tried it and it was working. I should close this now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This will fix some incompatibility issues with some node.js use-cases by handling over the module loading to require. This patch is dependent also to the patches I made with the thread-stream and real-require.
resolves #1237