Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the mixing logic #1335

Merged
merged 1 commit into from Feb 15, 2022
Merged

Refactor the mixing logic #1335

merged 1 commit into from Feb 15, 2022

Conversation

mcollina
Copy link
Member

No description provided.

jsumners
jsumners approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot better. It was very unclear to me in the other PR if the input was being overwritten.

@mcollina
Copy link
Member Author

This could be used as a basis for the other change.

@mcollina mcollina merged commit 3053a99 into master Feb 15, 2022
@mcollina mcollina deleted the refactor-mixin branch February 15, 2022 13:18
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcollina @jsumners