Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option mixinMergeStrategy (to v7) #1336

Merged
merged 1 commit into from Feb 15, 2022

Conversation

alexpts
Copy link
Contributor

@alexpts alexpts commented Feb 15, 2022

Forward port of #1328 to v7

@mcollina
Copy link
Member

PTAL for the changes that just landed, this conflicts now.
There was a prior bug that this PR is also solving.

@alexpts alexpts changed the title add option mixinMergeStrategy (to v7) WIP: add option mixinMergeStrategy (to v7) Feb 15, 2022
@alexpts alexpts changed the title WIP: add option mixinMergeStrategy (to v7) add option mixinMergeStrategy (to v7) Feb 15, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this looks good now.

@mcollina mcollina merged commit 83f9584 into pinojs:master Feb 15, 2022
@alexpts
Copy link
Contributor Author

alexpts commented Feb 15, 2022

@mcollina I need this option for v6.x also. Do you un-revert #1328 ?

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants