Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new err-serializer that serializes all error properties #134

Closed
wants to merge 1 commit into from

Conversation

satazor
Copy link
Member

@satazor satazor commented Nov 29, 2016

This replaces the core serializer with the one I made in https://github.com/IndigoUnited/pino-err-serializer.

Before merging, I need to port the tests to this repo. Any guidance to were these should be added?

There's https://github.com/pinojs/pino/blob/master/test/serializers.test.js but it doesn't actually test the core serializers.

@mcollina
Copy link
Member

Here it is https://github.com/pinojs/pino/blob/master/test/basic.test.js#L70-L90.

We can probably move that in its own test file.

Be careful that we need to handle also this case https://github.com/pinojs/pino/blob/master/pino.js#L242-L244.

@satazor
Copy link
Member Author

satazor commented Nov 30, 2016

@mcollina thanks for the hint, still haven't got time to port the tests. I'm currently busy at work, but will try to find some time this weekend. Alternatively, if someone has some time to help I would be much grateful.

@mcollina
Copy link
Member

Take your time ;). We are at Node Interactive and we won't have much time either!

@satazor
Copy link
Member Author

satazor commented Dec 4, 2016

@mcollina I'm wondering if serializers.test.js could be renamed to serializers-behavior.test.js (I tought initially that this would be the place to add the err-serializer tests) and if I could add a err-serializer.test.js.

@mcollina
Copy link
Member

mcollina commented Dec 5, 2016

Just add a err-serializer.test.js. It's a complex enough issue to have its own test file.
Don't worry too much on where the tests are, they can be moved easily.

@mcollina
Copy link
Member

hey @satazor, any updates on this?

@satazor
Copy link
Member Author

satazor commented Dec 14, 2016

Hey @mcollina, unfortunately no. I'm starting my own company and it drains all my time. This is not forgotten but I understand that you want to move on with this. What do you suggest?

@mcollina
Copy link
Member

mcollina commented Dec 14, 2016

@davidmarkclements @jsumners would you have some time to work on this? I'm currently blocked for most of this week.

@mcollina
Copy link
Member

mcollina commented Jan 3, 2017

Released as v3.1.0.

@mcollina mcollina closed this Jan 3, 2017
@jsumners jsumners deleted the err-serializer branch May 25, 2019 13:51
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants