Fix hasOwnProperty usage #1359
Merged
Fix hasOwnProperty usage #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under certain circumstances, the user's mergingObject may be passed
through as is to `write`. If the mergingObject was created with no
prototype (`Object.create(null)`), then calling hasOwnProperty will
fail.
Sample problematic code:
```js
const PinoMS = require('pino-multi-stream');
const pino = require('pino');
const logger = pino({}, pino.multistream([
{ stream: PinoMS.prettyStream({ prettyPrint: { colorize: true, translateTime: 'SYS:standard' } }) }
]));
const example = Object.create(null);
Object.assign(example, { hello: 'world' });
logger.info(example, 'hello world');
```
(This worked prior to Pino 7.8.0.)
For consistency, updated another usage of hasOwnProperty to match the
new style.
mcollina
requested changes
Mar 4, 2022
|
@mcollina Done. I apologize for the delay. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, the user's mergingObject may be passed through as is to
write. If the mergingObject was created with no prototype (Object.create(null)), then calling hasOwnProperty will fail.Sample problematic code:
(This worked prior to Pino 7.8.0.)
For consistency, I also updated another usage of hasOwnProperty to match the new style.