Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add h3 example #1385

Merged
merged 2 commits into from
Apr 8, 2022
Merged

docs: add h3 example #1385

merged 2 commits into from
Apr 8, 2022

Conversation

wobsoriano
Copy link
Contributor

No description provided.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

createServer(app).listen(process.env.PORT || 3000)
```

See the [pino-http readme](https://npm.im/pino-http) for more info.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See the [pino-http readme](https://npm.im/pino-http) for more info.
See the [pino-http readme](https://npm.im/pino-http) for more information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to change the rest of for more info to for more information?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, yes. But that does not seem to be in scope of this PR.

@mcollina mcollina merged commit bf19dd3 into pinojs:master Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants