Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not leak files when running tests #1395

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Do not leak files when running tests #1395

merged 2 commits into from
Apr 6, 2022

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Apr 6, 2022

Signed-off-by: Matteo Collina hello@matteocollina.com

Signed-off-by: Matteo Collina <hello@matteocollina.com>
test/helper.js Outdated Show resolved Hide resolved
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Co-authored-by: James Sumners <james@sumners.email>
@mcollina mcollina merged commit a71fdd5 into master Apr 6, 2022
@mcollina mcollina deleted the do-not-leak-files branch April 6, 2022 13:12
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants