Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to pass custom levels down to multistream() from transport #1398

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Add option to pass custom levels down to multistream() from transport #1398

merged 6 commits into from
Apr 8, 2022

Conversation

savardc
Copy link
Contributor

@savardc savardc commented Apr 7, 2022

Closes #1189

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test also for the JS part? Good work!

pino.js Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Apr 8, 2022

Good work!

@mcollina mcollina merged commit 03bb312 into pinojs:master Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need both multistream and transport to accomplish a task
2 participants