Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synchronous sleep in case of synchronous exit #1401

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Add synchronous sleep in case of synchronous exit #1401

merged 1 commit into from
Apr 8, 2022

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Apr 8, 2022

Fixes #1375

@mcollina mcollina requested a review from jsumners April 8, 2022 13:05
jsumners
jsumners approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.
giphy

@mcollina mcollina merged commit 89bb678 into master Apr 8, 2022
@mcollina mcollina deleted the sleep-before-end branch April 8, 2022 21:34
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flakyness in transport/core test
2 participants
@mcollina @jsumners