20-25% speed increase #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
added a commit
that referenced
this pull request
Mar 20, 2017
Using webpack with pino for serverside builds: #2
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flamegraph shows the bottleneck as stringify (from JSON.stringify):
We can also see the stringify function is not optimized (hence, slow)
By manually creating the initial string, we remove the stringify bottleneck
This yields savings of between 20 and 25%
benchPino_10000: 474.112ms
benchPino2_10000: 364.575ms
benchPinoObj_10000: 525.585ms
benchPinoObj2_10000: 413.634ms
benchPino_10000: 452.948ms
benchPino2_10000: 368.059ms
benchPinoObj_10000: 526.269ms
benchPinoObj2_10000: 428.568ms