browser write hook #218
Merged
browser write hook #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmarkclements
force-pushed
the
browser-write-hook
branch
from
5d9b5b8
to
aa6e685
Compare
jsumners
reviewed
Mar 21, 2017
browser.js
Outdated
| return logger | ||
| } | ||
|
|
||
| pino._Pino = Pino | ||
| // pino._Pino = Pino |
browser.js
Outdated
|
|
||
| function asObject (logger, levels) { | ||
| var k | ||
| for (var i in levels) { |
There was a problem hiding this comment.
levels is an array in here.
It looks a bit strange that you're using a normal for loop everywhere else except here.
| var proto = opts.browser.write || _console | ||
| if (opts.browser.write) opts.browser.asObject = true | ||
|
|
||
| var levels = ['error', 'fatal', 'warn', 'info', 'debug', 'trace'] |
There was a problem hiding this comment.
I guess you can move that array into the asObject function. You don't need it anywhere else.
There was a problem hiding this comment.
I do not want to allocate this every time we call asObject.
marcbachmann
approved these changes
Mar 21, 2017
davidmarkclements
force-pushed
the
browser-write-hook
branch
from
aa6e685
to
4457260
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asObjectoptionasObjectis mandatorily enabled ifwriteis suppliedcc @CyberThom @temsa