Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional opts to pretty formatter #317

Merged
merged 5 commits into from
Nov 7, 2017

Conversation

adam-26
Copy link
Contributor

@adam-26 adam-26 commented Oct 25, 2017

#316 - pretty dev formatter

I can improve the quality of tests if required, but its all very simple.

@adam-26
Copy link
Contributor Author

adam-26 commented Oct 25, 2017

@jsumners FYI

Modify test syntax for Node 4.x
Update API docs, add additional arg to function.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as semver-minor.

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners
Copy link
Member

jsumners commented Nov 5, 2017

@adam-26 the online conflict resolver is evidently useless. Would you mind resolving the conflict in this PR?

merge change(s) from master
@adam-26
Copy link
Contributor Author

adam-26 commented Nov 6, 2017

@jsumners, resolved. Please verify the changes are correct. The online resolver really is useless!

@jsumners jsumners merged commit 89e32ba into pinojs:master Nov 7, 2017
@adam-26 adam-26 deleted the pretty-dev-formatter branch November 9, 2017 00:53
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants