-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom levels to override default and allow to remove default levels #515
Conversation
Can you add this option to the docs? |
@mcollina sure! |
@mcollina Added to docs, let me know if you have any other requests! |
CI is failing. It seems Object.values is not available. |
@mcollina I added additional tests as well, I am not sure why CI is failing. Its failing because there isn't enough tests for a function initialising line. Should I write more tests for it? |
On Node 6: https://travis-ci.org/pinojs/pino/jobs/426109727. You are using some |
Updated to fit Node 6 API, still running into branch coverage problem. I covered all the cases that are possible with that function, not sure why its throwing that error. |
You can use |
@mcollina I figured out which branches wasn't covered. All the tests are passing, let me know if you have any comments on the implementation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jsumners added the warning! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Solves:
Reference : #507